-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scan the /patterns directory recursively to find patterns in subfolders. #53668
base: trunk
Are you sure you want to change the base?
Conversation
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @huubl! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
Any update on this? Would love to see this reviewed/added. @jorgefilipecosta @spacedmonkey |
Has there been any testing of this PR, or a review of if this is the correct approach? Because then I could potentially refresh this for 6.7. |
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @bgardner. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Unfortunately this PR is a bit outdated, I'd gladly take a look and review a refreshed one. |
@youknowriad there is already a core patch with a different approach https://core.trac.wordpress.org/ticket/62378 |
Do you think it's possible to try in Gutenberg to validate it first? |
Related:
What?
Right now patterns can't be organized in subfolders, like template parts.
I'm not sure if this needs to be added to:
gutenberg/lib/compat/wordpress-6.2/block-patterns.php
or somewhere else and what to set as@since
?Furthermore, there are at least two functions that are similar and can perhaps be combined into one function:
json-resolver-gutenberg.php#L703-L715 (Gutenberg plugin)
block-template-utils.php#L223-L242 (Wordpress Core)
Why?
Better organize pattern files.
How?
Scan the /patterns directory recursively to find patterns in subfolders.
Testing Instructions
Testing Instructions for Keyboard
--
Screenshots or screencast
--