-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Query block: Move "Enhance pagination" toggle under Settings #54198
Merged
luisherranz
merged 2 commits into
trunk
from
update/interactivity-api-enhanced-query-loop-setting
Sep 6, 2023
Merged
Query block: Move "Enhance pagination" toggle under Settings #54198
luisherranz
merged 2 commits into
trunk
from
update/interactivity-api-enhanced-query-loop-setting
Sep 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DAreRodz
added
[Type] Enhancement
A suggestion for improvement.
[Block] Query Loop
Affects the Query Loop Block
[Feature] Site Editor
Related to the overarching Site Editor (formerly "full site editing")
[Feature] Interactivity API
API to add frontend interactivity to blocks.
labels
Sep 5, 2023
21 tasks
Size Change: -9 B (0%) Total Size: 1.51 MB
ℹ️ View Unchanged
|
5 tasks
luisherranz
approved these changes
Sep 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me 🙂
I'll add the Backport to RC label so this gets merged before releasing 16.6.
luisherranz
added
Backport to Gutenberg RC
Pull request that needs to be backported to a Gutenberg release candidate (RC)
and removed
[Feature] Site Editor
Related to the overarching Site Editor (formerly "full site editing")
labels
Sep 6, 2023
luisherranz
deleted the
update/interactivity-api-enhanced-query-loop-setting
branch
September 6, 2023 08:09
Mamaduka
removed
the
Backport to Gutenberg RC
Pull request that needs to be backported to a Gutenberg release candidate (RC)
label
Sep 21, 2023
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Block] Query Loop
Affects the Query Loop Block
[Feature] Interactivity API
API to add frontend interactivity to blocks.
Needs User Documentation
Needs new user documentation
[Type] Enhancement
A suggestion for improvement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Remove the "User Experience" dedicated panel, and move the "Enhance pagination" toggle under Settings, also modifying the toggle's description for one with a more positive tone.
Will close #54059.
Why?
To improve how we present the new enhanced mode for the Query loop in the Site Editor (see #53812 (comment)).
How?
Just moving the corresponding
ToggleControl
to the right position.Testing Instructions
You can use https://playground.wordpress.net/gutenberg.html to test this PR.
Screenshots or screencast