-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patterns: Add category selectors to the patterns package #55825
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: +129 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
Flaky tests detected in 197dd99. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6740394937
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds a new selector to get all pattern categories to the patterns package as an alternative to #55822 which combines the categories on the existing pattern categories rest API
Why?
Currently we combine the core and user pattern categories in a number of different places between post editor and site editor. It would be better to have a single selector that provided the combined categories.
The advantage of this approach is that there are no backwards compat issues with changing API endpoint responses.
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast