Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heading level dropdown: remove obtrusive tooltips in favor of visible text #56035

Merged
merged 3 commits into from
Nov 16, 2023
+2 −2
Merged

Heading level dropdown: remove obtrusive tooltips in favor of visible text #56035

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ff09b4a
Remove heading level dropdown tooltip in favor of visible text.
afercia Nov 10, 2023
0519c51
Adjust test.
afercia Nov 10, 2023
126c443
Remove CSS changes.
afercia Nov 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/block-editor/src/components/block-heading-level-dropdown/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ export default function HeadingLevelDropdown( {
isPressed={ isActive }
/>
),
label:
title:
targetLevel === 0
? __( 'Paragraph' )
: sprintf(
Expand Down
5 changes: 5 additions & 0 deletions packages/block-editor/src/components/block-heading-level-dropdown/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
.block-library-heading-level-dropdown {
.components-dropdown-menu__menu-item.has-icon.has-text {
gap: $grid-unit-15;
}
}
1 change: 1 addition & 0 deletions packages/block-editor/src/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
@import "./components/block-card/style.scss";
@import "./components/block-compare/style.scss";
@import "./components/block-draggable/style.scss";
@import "./components/block-heading-level-dropdown/style.scss";
@import "./components/block-mover/style.scss";
@import "./components/block-navigation/style.scss";
@import "./components/block-parent-selector/style.scss";
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/specs/editor/various/rich-text.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ test.describe( 'RichText', () => {
// See: https://github.com/WordPress/gutenberg/issues/3091
await editor.insertBlock( { name: 'core/heading' } );
await editor.clickBlockToolbarButton( 'Change level' );
await page.locator( 'button[aria-label="Heading 3"]' ).click();
await page.locator( 'role=menuitemradio[name="Heading 3"]' ).click();

expect( await editor.getBlocks() ).toMatchObject( [
{
Expand Down
Loading