-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DataViews: hide actions menu upon selecting a layout #57418
Merged
oandregal
merged 2 commits into
trunk
from
update/hide-action-menu-upon-selecting-layout
Dec 28, 2023
Merged
DataViews: hide actions menu upon selecting a layout #57418
oandregal
merged 2 commits into
trunk
from
update/hide-action-menu-upon-selecting-layout
Dec 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oandregal
added
[Type] Experimental
Experimental feature or API.
[Feature] DataViews
Work surrounding upgrading and evolving views in the site editor and beyond
labels
Dec 28, 2023
Size Change: +11 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
ciampo
reviewed
Jan 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙏 Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] DataViews
Work surrounding upgrading and evolving views in the site editor and beyond
[Type] Experimental
Experimental feature or API.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #55083
Related #55083 and #55625
What?
Hide the view actions menu upon selecting a layout.
Why?
Upon selecting a layout, the position of the view actions menu trigger could change. For example, when switching from table to list. This leaves the dropdown in a weird visual position.
This had been fixed at #57015 but resurfaced after #55625
How?
Use
hideOnClick
to hide the dropdown upon selection a layout option.Testing Instructions