Template editing: Refactor the post editor template-only mode #57633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…getPostLinkProps` setting to change the currently edited entity
glendaviesnz
added
[Type] Code Quality
|
This is still very draft and not reading for testing. |
|
Size Change: -51 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
…ost type now has history it doesn't show the padding around the editor
49 tasks
glendaviesnz
removed
[Type] Code Quality
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
|
Closed as going to need to tackle in smaller parts as we need to work out which bits of the existing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Refactors the post editor
template-onlymode to instead use the #57036 to pass a new entity into the editor provider.Why?
It was decided that passing a new entity into the editor provider was a better way of moving between different entities in the editor rather than adding multiple rendering modes for templates, patterns, navigation blocks, etc.
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast