Allow heading and button in Pattern Overrides #57789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin940726
added
[Feature] Synced Patterns
kevin940726
requested review from
talldan,
gziolo,
glendaviesnz and
aaronrobertshaw
|
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ lib/block-supports/pattern.php |
|
Size Change: -1.33 kB (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
talldan
reviewed
Jan 15, 2024
Comment on lines
+16
to
+17
| global $block_bindings_allowed_blocks; | ||
| $pattern_support = array_key_exists( $block_type->name, $block_bindings_allowed_blocks ); |
There was a problem hiding this comment.
Now it fails in trunk
Uncaught TypeError: array_key_exists(): Argument #2 ($array) must be of type array, null given in /plugins/gutenberg/lib/block-supports/pattern.php:17
There was a problem hiding this comment.
No worries @michalczaplinski! Thanks for approving and merging that PR, good to get it across the line!
packages/patterns/src/constants.js
Outdated
| @@ -23,4 +23,6 @@ export const PATTERN_SYNC_TYPES = { | |||
| // TODO: This should not be hardcoded. Maybe there should be a config and/or an UI. | |||
| export const PARTIAL_SYNCING_SUPPORTED_BLOCKS = { | |||
| 'core/paragraph': { content: __( 'Content' ) }, | |||
| 'core/heading': { content: __( 'Content' ) }, | |||
| 'core/button': { text: __( 'Text' ) }, | |||
There was a problem hiding this comment.
Should it also support the URL? It is editable in the UI, but doesn't work at the moment, possibly because it's missing here.
There was a problem hiding this comment.
Same with the various URL connected attributes such as rel, opening in a new tab etc.
There was a problem hiding this comment.
Yeah, I was thinking about that too. It's something that block bindings would need to support as well:
https://github.com/WordPress/gutenberg/pull/57742/files#diff-13ba237ac22cd8b66e7ec6447ae508cd6385d2e6e1e4cd1ae8f73c4bdf62136fR33
There was a problem hiding this comment.
If I am not mistaken, the URL of the button should work as well. It was included in the first pull request: link. Adding most attributes should be as easy as adding them to the relevant array, so we can try to add anything you consider relevant.
There was a problem hiding this comment.
Great, let's try adding them in a follow-up PR.
There was a problem hiding this comment.
url support was added in 585a658!
49 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #53705. Allow
core/headingandcore/buttonin Pattern Overrides.Why?
Allow more blocks to be overridable.
How?
Add them to the hardcoded allowed list.
Testing Instructions
Follow the instructions in #53705 (comment), but also add some headings and buttons.
Screenshots or screencast
TBD