Cherry-pick 16.5 RC package changes #57852
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restore ReactRefreshWebpackPlugin to @wordpress/scripts webpack config. #57461 accidentally moved the plugin to the modules config. It should have remained in the scripts webpack config and not been included in the modules config.
…les (#57795) WordPress Script dependencies are not currently available as dependencies of WordPress Modules. Using e.g. lodash or @wordpress/api-fetch in a module build would result in bundling that dependency. For a package like lodash that's undesirable but should work. However, many @wordpress/* packages are not intended to be bundle or duplicated and will not work as expected. It's likely an error to use WordPress Scripts inside modules at this time. --------- Co-authored-by: Luis Herranz <[email protected]>
Package publishing via GitHub Actions is currently broken because the actions are not passing the npm version check. This check was introduced when package-lock formats were changing frequently and causing issues. Those difficulties seem to have passed for the most part.
sirreal
requested review from
gziolo,
ntwb,
nerrad,
ajitbohra and
ryanwelcher
as code owners
sirreal
added
the
[Type] Task
|
Size Change: 0 B Total Size: 1.69 MB ℹ️ View Unchanged
|
|
It's probably a bad idea to merge this. For the same reason I can't push to I'll close this, but someone with privileges could use this to proceed with package publishing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Packages were never published with the Gutenberg 16.5 RC.
#57797 should fix the publish package flow, but we need to release packages.
I'm following this guide to do a bugfix package release, but
wp/latestis a protected branch so I cannot push directly. I've created this PR to push the cherry-picked changes to thewp/latestbranch in order to publish packages.Everything with the "Backport to Gutenberg RC" label has been cherry-picked: