Add BlockJsonDependenciesPlugin to modules build #57927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirreal
requested review from
gziolo,
ntwb,
nerrad,
ajitbohra and
ryanwelcher
as code owners
sirreal
added
[Type] Task
|
Size Change: 0 B Total Size: 1.69 MB ℹ️ View Unchanged
|
sirreal
added
[Type] Enhancement
|
This needs a changelog entry. |
gziolo
approved these changes
Feb 7, 2024
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core SVNCore Committers: Use this line as a base for the props when committing in SVN: GitHub Merge commitsIf you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
sirreal
force-pushed
the
fix/watch-block-json-module-build
branch
from
6d82697 to
c6cb4a3
Compare
sirreal
force-pushed
the
fix/watch-block-json-module-build
branch
from
c6cb4a3 to
7c285c9
Compare
Add a plugin that finds block.json files and adds them as fileDependencies of the module build. This ensures that changes to block.json files trigger updates to the module build. See https://webpack.js.org/contribute/plugin-patterns/ > You may also feed new file paths into the watch graph to receive > compilation triggers when those files change. Add valid file paths > into the `compilation.fileDependencies` Set to add them to the > watched files.
sirreal
force-pushed
the
fix/watch-block-json-module-build
branch
from
7c285c9 to
66082a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add a plugin that finds block.json files and adds them as
fileDependencies of the module build. This ensures that changes to
block.json files trigger updates to the module build.
See https://webpack.js.org/contribute/plugin-patterns/
d_.mov
Why?
@gziolo noticed that changes to block.json files wouldn't trigger changes to the module build (#57461 (comment))
Testing Instructions
To test this, you'll want to check this out and link it to a project that depends on @wordpress/scripts.
If you use
wp-scripts start, changes to anyblock.jsonfiles in the project should trigger a rebuild. Changes to theviewModulefield should change the compilation.