Embed Block: Fix retry processing when embedding with trailing slash fails #58007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
|
Size Change: 0 B Total Size: 1.7 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 9e61fee. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7584549887
|
t-hamano
removed
the
[Type] Bug
t-hamano
commented
Jan 19, 2024
Comment on lines
124
to
+125
| 'WordPress invalid content. Should render failed, edit state.' | ||
| ).toHaveValue( 'https://wordpress.org/gutenberg/handbook/' ); | ||
| ).toHaveValue( 'https://wordpress.org/gutenberg/handbook' ); |
There was a problem hiding this comment.
Personally, I think that if the embed fails even if the URL does not have a trailing slash, we should restore it to the original URL.
However, that implementation is not done in #14705 and will require major modifications. If necessary, I think we can respond with follow-up PR.
t-hamano
requested review from
kevin940726,
Mamaduka and
ajitbohra
as code owners
Mamaduka
approved these changes
Jan 21, 2024
|
@Mamaduka Thanks for the review! |
|
@t-hamano, I think we introduced a regression here. The embed block now retries providers that can be embedded with trailing slash. I discovered while I was debugging flaky embed e2e test - #37503 Update: Started working on the fix in #60655. Testing instructions
Screenshot
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #58002
What?
This PR fixes an issue where retrying when embedding a URL with a trailing slash fails, implemented in #14705, was not working.
Why?
As far as I can tell, this regression occurred when class components were rewritten to function components in #22845.
https://github.com/WordPress/gutenberg/pull/22846/files?diff=unified&w=1#diff-ef12826bc6a57e80852c9800c4bb8db0157db2b1f1418686fc85088e5438bb78R106-R108
Originally, if a URL with a trailing slash could not be embedded, this block would remove the trailing slash and try to embed it again.
The current conditional statement performs the early return and skips retrying the embed if the preview HTML could NOT be retrieved. I think the expected behavior should be to skip retrying the embed if the preview HTML could be retrieved.
How?
I reversed the conditional statement. Accordingly, I have re-enabled the skipped tests.
Testing Instructions
https://twitter.com/WordPress/in the URL.https://twitter.com/WordPress).https://x.com/WordPress/). It will be translated to thetwitter.comdomain, which is the expected behavior in the current implementation.