-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Font Library: Remove WP_Font_Family class that is no longer used. #58184
Conversation
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ lib/load.php |
Flaky tests detected in 6134d72. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7640757532
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Font Library continues to work as expected. Unit tests continue to pass.
This change looks good to me.
I noticed this PR was merged after I raised the PHP Sync Tracking Issue for WP 6.5 and has changed PHP files that may need backporting to WP Core. I believe this will be backported as part of a single backport for the Fonts API. It's been added to the Tracking Issue. |
This PR was already in |
Thanks @c4rl0sbr4v0 for checking! We had a number of smaller font library PRs to touch things up in the last week, I wasn't sure which ones made it into the rc or not. |
What?
Remove
WP_Font_Family
class and its tests.Why?
Because it's no longer used after #57688
How?
Removing the source code file and its tests.
Testing Instructions