Fix fonts modal dialog buttons accessibility. #58309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afercia
added
[Type] Bug
|
Size Change: -3 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
afercia
force-pushed
the
fix/fonts-modal-dialog-buttons
branch
from
66bae73 to
ac488bd
Compare
|
Rebased after changes from #58180 |
mikachan
approved these changes
Jan 26, 2024
|
Thanks for the review @mikachan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #58060
What?
The back button in the Fonts modal dialog is unlabeled.
Why?
All icon buttons must be labelled and show a tooltip, to visually expose their accessible name.
How?
<span>element from the Upload font button.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast