DataViews: Update folders structure #58430
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Code Quality
mcsf
approved these changes
Jan 30, 2024
|
I'm fine with this, though my only objection is that this PR doesn't make backporting fixes for WordPress RC harder. (check that this is going in the gutenberg version that is bundled for WP). |
|
#56721 (comment) I prefer |
|
Size Change: 0 B Total Size: 1.7 MB ℹ️ View Unchanged
|
How would this affect the backporting? 🤔 |
ntsekouras
force-pushed
the
update/dataviews-folder-structure
branch
from
bebcea6 to
43949e7
Compare
|
@ntsekouras in situations where two branches have different folder structure. If this PR is part of WP is fine (same folder structure in trunk and |
|
Flaky tests detected in ce72127effbd71bba780d78805c81e758d8fa0a8. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7710304262
|
After discussing this in private, I no longer endorse this. :P But I also don't mean to block. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This is just a bit house keeping in DataViews package, where I added some folders to separate a bit the files.
We could do more as we add more and intentionally I didn't suggest many changes right now - just three new folders(filters,views,actions).