Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Font Library REST API code to align with Core standards #58619

Merged
merged 4 commits into from
Feb 2, 2024
Merged

Update Font Library REST API code to align with Core standards #58619

merged 4 commits into from
Feb 2, 2024

Conversation

getdave
Copy link
Contributor

@getdave getdave commented Feb 2, 2024 •
edited
Loading

What?

Aligns the Font Library REST API code with Core PHP standards.

See #55277 (comment)

Co-authored-by: getdave [email protected]
Co-authored-by: anton-vlasenko [email protected]
Co-authored-by: pbking [email protected]

Why?

How?

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

@getdave getdave added [Type] Code Quality Issues or PRs that relate to code quality [Feature] Font Library labels Feb 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 2, 2024 •
edited
Loading

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files
❔ lib/compat/wordpress-6.5/fonts/class-wp-rest-font-collections-controller.php
❔ lib/compat/wordpress-6.5/fonts/class-wp-rest-font-faces-controller.php
❔ lib/compat/wordpress-6.5/fonts/class-wp-rest-font-families-controller.php

@getdave getdave marked this pull request as ready for review February 2, 2024 14:39
@getdave getdave requested a review from spacedmonkey as a code owner February 2, 2024 14:39
@getdave getdave mentioned this pull request Feb 2, 2024
Closed
25 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 2, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core SVN

If you're a Core Committer, use this list when committing to wordpress-develop in SVN:

Props: get_dave, antonvlasenko, pbking, mmaattiiaass.

GitHub Merge commits

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: getdave <[email protected]>
Co-authored-by: anton-vlasenko <[email protected]>
Co-authored-by: pbking <[email protected]>
Co-authored-by: matiasbenedetto <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@getdave
Copy link
Contributor Author

getdave commented Feb 2, 2024

@anton-vlasenko Are we in a good place to merge this now?

@anton-vlasenko
Copy link
Contributor

@getdave Yes, I believe this PR can be merged. I cannot find anything suspicious.

matiasbenedetto
matiasbenedetto approved these changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@matiasbenedetto matiasbenedetto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvements. It looks good to me

@matiasbenedetto matiasbenedetto enabled auto-merge (squash) February 2, 2024 21:44
@matiasbenedetto matiasbenedetto merged commit 38fbc7f into trunk Feb 2, 2024
57 checks passed
@matiasbenedetto matiasbenedetto deleted the update/font-lib-rest-code-align-core-standards branch February 2, 2024 22:03
@github-actions github-actions bot added this to the Gutenberg 17.7 milestone Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matiasbenedetto matiasbenedetto matiasbenedetto approved these changes

@pbking pbking pbking approved these changes

@ironprogrammer ironprogrammer Awaiting requested review from ironprogrammer

@creativecoder creativecoder Awaiting requested review from creativecoder

@anton-vlasenko anton-vlasenko Awaiting requested review from anton-vlasenko

@spacedmonkey spacedmonkey Awaiting requested review from spacedmonkey spacedmonkey is a code owner

Assignees
No one assigned
Labels
[Feature] Font Library [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
Gutenberg 17.7
Development

Successfully merging this pull request may close these issues.
4 participants
@getdave @anton-vlasenko @pbking @matiasbenedetto