Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experiment: Add full page client-side navigation experiment setting #59707
Experiment: Add full page client-side navigation experiment setting #59707
Changes from all commits
6a1b29a
a5b6dd0
cf8e72b
8ddc122
32cd62c
cc25473
dffa452
7412f98
f92355d
04b94a9
ca90d0a
34e6b22
4f67b70
592b842
1593483
afda3e6
195e7e7
c8348ab
69a70d6
9b2c853
8f16b30
7f458b1
1d96c64
63c81a6
652a2a2
442248c
0f3bc44
62f6948
a26bfa7
a5a7279
f984294
0f7a8db
cd7a112
dd2b73e
7eef1ce
f0fecee
7081358
1d00a3c
a318179
2138f0d
79eac03
5dcaa1d
fb5f911
afa7127
79768b6
181614e
36e0901
455b8d7
a2c1a07
f7e5212
8f09d2b
743926f
44d0873
eeb6491
46ce031
57ef83c
a5b9e80
4f9d728
d7e6ddb
d72cd02
745e675
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the stylesheet remains the same, I think it should be left as-is. Otherwise, removing a stylesheet and then adding it right back in will likely cause a performance problem.
Example: https://mousy-citrine-lotus.glitch.me/
Note there is a flash of unstyled content. It also causes layout and style recalculation:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to be able to reuse DOM diffing from Preact here. (Not sure if that's possible.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a follow-up task to this list to explore this after this experiment is merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried using Preact at first, but if the scripts and styles change order or new elements appear in the head, Preact gets confused and deletes and re-adds everything.
I think it will be simpler and more stable if we control it ourselves.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For styles we should use
element.textContent
becauseinnerText
might cause areflow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added it as a follow-up to explore after this experiment.