Animation: Avoid fixed width when animating the secondary sidebar #60693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
youknowriad
added
[Type] Enhancement
|
Size Change: +40 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
|
This PR introduced a bug where the inserter and list view are not full-width on mobile |
|
There is also a random 
|
|
So this small patch would fix the problem: diff --git a/packages/interface/src/components/interface-skeleton/index.js b/packages/interface/src/components/interface-skeleton/index.js
index 6e30a1c9312..6550a5d403d 100644
--- a/packages/interface/src/components/interface-skeleton/index.js
+++ b/packages/interface/src/components/interface-skeleton/index.js
@@ -171,7 +171,9 @@ function InterfaceSkeleton(
<div
style={ {
position: 'absolute',
- width: 'fit-content',
+ width: isMobileViewport
+ ? '100vw'
+ : 'fit-content',
height: '100%',
right: 0,
} }But I am unsure of what we want to achieve, because the small |
|
Oh it seems the sidebars on mobile are now hiding the header whereas in current WP they don't: 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #60679
What?
A quick follow-up/exploration for #60665 to make zoom out work with the improved animated panels. It's not incredibly smooth either, but perhaps helps finds a proper solution.
Testing Instructions