Editor: Do not show scrollbars when closing sidebars #60889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +48 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
stokesman
approved these changes
Apr 19, 2024
There was a problem hiding this comment.
I tested in the Post and Site editors and it fixes the issue. I was sure to also test with the sidebar scrolled to make sure the overflow change didn’t cause position: sticky elements to jump out of place and they are fine. 🚀
editor-right-sidebar-horizontal-scrollbar-fixed.mp4
|
Thanks for testing ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
In #60561 we added an animation to the opening/closing of the editor sidebars. It causes a small issue where the scrollbar is shown during the animation (when the width of the content of the sidebar exceeds its size). This PR tweaks the CSS a bit to avoid this.
Testing Instructions
1- Open the post editor (or site editor)
2- Make sure you have "scrollbars visible" in your OS config
3- Check that the scrollbars don't show up during the animation.