Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Add AutosaveMonitor component JSDoc enhancements #60905

Merged

Conversation

colorful-tones
Copy link
Member

@colorful-tones colorful-tones commented Apr 19, 2024

What?

This is a follow-up to #60882—Adding documentation for the AutosaveMonitor component. @ntsekouras noted a small change, but it's a good one to merge and consolidate some of the JSDocs.

Preview of final, generated editor README is here: https://github.com/colorful-tones/gutenberg/tree/add/autosavemonitor-doc-enhancements/packages/editor#autosavemonitor

Why?

There are a great number of APIs in the editor package that are lacking documentation. We aim to address these one by one. See #60358 for a full checklist. This is just the first item on the list 😉

How?

Add a JSDoc comment to the AutosaveMonitor component and run npm run docs:build to populate the README with the newly added documents.

Copy link

github-actions bot commented Apr 19, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: colorful-tones <[email protected]>
Co-authored-by: ntsekouras <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@colorful-tones colorful-tones added [Type] Developer Documentation Documentation for developers [Package] Editor /packages/editor labels Apr 19, 2024
@colorful-tones colorful-tones changed the title Add/autosavemonitor doc enhancements Documentation: Add AutosaveMonitor component JSDoc enhancements Apr 19, 2024
Copy link
Contributor

@ntsekouras ntsekouras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with a minor comment. Thanks for the follow up!

packages/editor/README.md Show resolved Hide resolved
Copy link
Contributor

@ntsekouras ntsekouras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you again for all your efforts @colorful-tones!

@ntsekouras ntsekouras merged commit 0c4eab6 into WordPress:trunk Apr 26, 2024
63 of 64 checks passed
@github-actions github-actions bot added this to the Gutenberg 18.3 milestone Apr 26, 2024
huubl pushed a commit to huubl/gutenberg that referenced this pull request Apr 26, 2024
@colorful-tones colorful-tones deleted the add/autosavemonitor-doc-enhancements branch April 26, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Editor /packages/editor [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants