Add lib-font credits and license in source code #60973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
matiasbenedetto
added
[Type] Code Quality
|
Size Change: +21 B (0%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 5c80898. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/8791088164
|
mikachan
approved these changes
Jun 18, 2024
There was a problem hiding this comment.
Thanks for doing this, @matiasbenedetto. Additions look good to me and are in line with other licenses like serialize.js 👍
|
This PR has been added to the 6.6 Editor tasks board, but I noticed that GitHub Actions is down. Therefore, I updated this PR and started GitHub Actions again. I would be happy if you could merge it once it has gone through all the GitHub Actions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add lib-font credits and license in the source code.
Until we find a way to install the package as an npm dependency the relevant package files were copied to the Gutenberg codebase.
Why?
It is appropriate to add the package credits following examples like serialize.js.
How?
Adding the credits in the same format as other js files in the codebase.
Testing Instructions
No code changes were added. Only credits and license info as comments.