Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Components: Make the
ProgressBar
public #61062Components: Make the
ProgressBar
public #61062Changes from all commits
023e5c4
b1fe7cd
fe9129d
64c72e2
c88ece0
ad0fff9
dc299ed
4c0b8fd
0ff6637
ad2fd28
adf39a1
ceb2840
9b3db94
a219fa8
1d22f24
b096ca4
3af0985
846ccc0
39b92a5
3241379
ff982fb
b0eca3f
59d46cc
0832e40
5ca947a
47183b7
eed1dba
d132170
43e1a57
c0bd79d
2f978f4
433d249
1b4dc84
17b0d30
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've always felt we duplicate so much README and add overhead for maintaining these docs in the future 😕 I wonder if we can improve/automate that somehow - perhaps a command to allow the README to inherit content from here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My initial plans were to abandon the manual readmes altogether once the Storybook was "complete" with all the type data and documentation. I do consider it pretty much complete now. But @DaniGuardiola mentioned some kind of TSDoc to markdown docgen he has up his sleeve, so that could be another option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ref: https://github.com/Create-Inc/archetype/?tab=readme-ov-file#createincarchetype-docgen
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. It would be fun to try something like this out here @DaniGuardiola 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I share the non-DRY feelings here, too. A way to extract and keep everything from/in a central place would be nice 👍🏻