Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clarification about importing css/scss files #61252

Merged

Conversation

colorful-tones
Copy link
Member

@colorful-tones colorful-tones commented Apr 30, 2024

What?

Additional clarification in Block Editor Handbook / How-to Guides / Blocks / Use styles and stylesheets to remind folks that they will need to import './editor.scss' in their edit.js, etc.

I've forgotten and missed this rather obvious detail a few times. Also, I requested clarification on this yesterday, which inspired the follow up PR: #54491 (comment)

Why?

Trying to empower folks to understand and use standard approaches.

How?

Clarification in documentation

Preview changes here: https://github.com/WordPress/gutenberg/pull/61252/files#diff-5fa0fb78d92f47c4d5770f668b186c3c3ea593e5fdb2d2b2a8ce3d2f2c775c03

Copy link

github-actions bot commented Apr 30, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @ALJ.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: ALJ.

Co-authored-by: colorful-tones <[email protected]>
Co-authored-by: fabiankaegy <[email protected]>
Co-authored-by: juanmaguitar <[email protected]>
Co-authored-by: luminuu <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@colorful-tones colorful-tones added the [Type] Developer Documentation Documentation for developers label Apr 30, 2024
@luminuu
Copy link
Member

luminuu commented Apr 30, 2024

Here's the issue that @juanmaguitar added based on my feedback in Slack recently, covering this topic: #61092

@colorful-tones colorful-tones enabled auto-merge (squash) May 29, 2024 15:07
@juanmaguitar
Copy link
Contributor

@colorful-tones there seems to be an issue with some tests that shouldn't be affected by this PR.
could you run the tests again to check if this unblocks the merge of this PR?

@colorful-tones
Copy link
Member Author

It has been a while and already struggling with how to contribute to docs. We really need to improve docs for new contributors and even existing! I can't remember what I had for lunch yesterday, and unless you're contributing docs every day then you're really gonna struggle.

Steps so far:

@colorful-tones colorful-tones force-pushed the update/block-tutorial-styles branch from fe22c83 to e7c6913 Compare August 7, 2024 20:22
@colorful-tones colorful-tones merged commit ddadd1a into WordPress:trunk Aug 7, 2024
58 checks passed
@github-actions github-actions bot added this to the Gutenberg 19.1 milestone Aug 7, 2024
@colorful-tones
Copy link
Member Author

Guess I was overthinking it. (hint: I always do 😉 ).

@colorful-tones colorful-tones deleted the update/block-tutorial-styles branch August 7, 2024 21:13
@juanmaguitar
Copy link
Contributor

Thanks @colorful-tones!

could you run the tests again to check if this unblocks the merge of this PR?

I should have clarified that I meant the tests are launched automatically on each PR as part of the Continuous Integration processes.
Sometimes tests fail in PR, and most of the time the issue is solved by running the tests again, which can be done from PR GitHub UI without any code changes.

PS: I see you already successfully managed that, but I wanted to leave this explanation here for further reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants