-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add clarification about importing css/scss files #61252
Add clarification about importing css/scss files #61252
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @ALJ. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Here's the issue that @juanmaguitar added based on my feedback in Slack recently, covering this topic: #61092 |
docs/how-to-guides/block-tutorial/applying-styles-with-stylesheets.md
Outdated
Show resolved
Hide resolved
docs/how-to-guides/block-tutorial/applying-styles-with-stylesheets.md
Outdated
Show resolved
Hide resolved
@colorful-tones there seems to be an issue with some tests that shouldn't be affected by this PR. |
It has been a while and already struggling with how to contribute to docs. We really need to improve docs for new contributors and even existing! I can't remember what I had for lunch yesterday, and unless you're contributing docs every day then you're really gonna struggle. Steps so far:
|
fe22c83
to
e7c6913
Compare
Guess I was overthinking it. (hint: I always do 😉 ). |
Thanks @colorful-tones!
I should have clarified that I meant the tests are launched automatically on each PR as part of the Continuous Integration processes. PS: I see you already successfully managed that, but I wanted to leave this explanation here for further reference. |
What?
Additional clarification in Block Editor Handbook / How-to Guides / Blocks / Use styles and stylesheets to remind folks that they will need to
import './editor.scss'
in theiredit.js
, etc.I've forgotten and missed this rather obvious detail a few times. Also, I requested clarification on this yesterday, which inspired the follow up PR: #54491 (comment)
Why?
Trying to empower folks to understand and use standard approaches.
How?
Clarification in documentation
Preview changes here: https://github.com/WordPress/gutenberg/pull/61252/files#diff-5fa0fb78d92f47c4d5770f668b186c3c3ea593e5fdb2d2b2a8ce3d2f2c775c03