Fix: Check Capability to create pages on DataViews add new page button #62592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s add new page button.
jorgefilipecosta
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +29 B (0%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
carolinan
approved these changes
Jun 18, 2024
jorgefilipecosta
deleted the
fix/capability-to-create-pages-is-not-taken-into-account-when-showing-add-new-page-button
branch
ellatrix
pushed a commit
that referenced
this pull request
Jun 25, 2024
#62592) Co-authored-by: jorgefilipecosta <[email protected]> Co-authored-by: carolinan <[email protected]>
|
I just cherry-picked this PR to the wp/6.6-rc-1 branch to get it included in the next release: 3b10fb7 |
ellatrix
added
Backported to WP Core
ellatrix
pushed a commit
that referenced
this pull request
Jun 25, 2024
#62592) Co-authored-by: jorgefilipecosta <[email protected]> Co-authored-by: carolinan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We display the "Add New Page" option for all users, causing errors for those without page creation capabilities.
This PR fixes the issue we now check if the user is able to create pages when rendering the button.
Testing Instructions
I pasted this test code on load.php to remove the capability to create pages:
I went to
/wp-admin/site-editor.php?postType=pageand verified that "Add New Page" button was not available.