Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post Template: Add Border and Spacing Support #64425

Open
wants to merge 7 commits into
base: trunk
Choose a base branch
from
+14 −2
Open

Post Template: Add Border and Spacing Support #64425

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
09db420
Post Template: Add Border and Spacing Support
shail-mehta Aug 11, 2024
abd4087
fix conflict issue
shail-mehta Dec 21, 2024
852a15b
Added Border & Spacing Controls Optional
shail-mehta Aug 12, 2024
1c77a98
fix conflict issue
shail-mehta Dec 21, 2024
4069e59
Fixed Lint Issue
shail-mehta Dec 21, 2024
f0e5c38
Added Suggested Changes
shail-mehta Dec 22, 2024
8c4dcf1
Added Suggested Changes
shail-mehta Dec 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/reference-guides/core-blocks.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -661,7 +661,7 @@ Contains the block elements used to render a post, like the title, date, feature
- **Name:** core/post-template
- **Category:** theme
- **Ancestor:** core/query
- **Supports:** align (full, wide), color (background, gradients, link, text), interactivity (clientNavigation), layout, spacing (blockGap), typography (fontSize, lineHeight), ~~html~~, ~~reusable~~
- **Supports:** align (full, wide), color (background, gradients, link, text), interactivity (clientNavigation), layout, spacing (blockGap, margin, padding), typography (fontSize, lineHeight), ~~html~~, ~~reusable~~

## Post Terms

Expand Down
12 changes: 11 additions & 1 deletion packages/block-library/src/post-template/block.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,15 +43,25 @@
}
},
"spacing": {
"margin": true,
"padding": true,
"blockGap": {
"__experimentalDefault": "1.25em"
},
"__experimentalDefaultControls": {
"blockGap": true
"blockGap": true,
"padding" : false,
"margin" : false
}
},
"interactivity": {
"clientNavigation": true
},
"__experimentalBorder": {
"radius": true,
"color": true,
"width": true,
"style": true
}
},
"style": "wp-block-post-template",
Expand Down
2 changes: 2 additions & 0 deletions packages/block-library/src/post-template/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
max-width: 100%;
list-style: none;
padding: 0;
// This block has customizable padding, border-box makes that more predictable.
box-sizing: border-box;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
box-sizing: border-box;
// This block has customizable padding, border-box makes that more predictable.
box-sizing: border-box;

As with any block, it's a good idea to add comments.


// These rules no longer apply but should be kept for backwards compatibility.
&.is-flex-container {
Expand Down
Loading