QueryControls: Default to new 40px size #64457
Conversation
mirka
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
| * Start opting into the larger default height that will become the | ||
| * default size in a future version. |
There was a problem hiding this comment.
Should we remove the old docs as they're no longer relevant?
| * Start opting into the larger default height that will become the | |
| * default size in a future version. |
There was a problem hiding this comment.
I'm hoping it will be helpful to extenders, at least for a while, until this deprecation propagates. They will see the prop marked as deprecated in their IDEs, and they might want to know what that prop was about.
* QueryControls: Default to new 40px size * Add changelog Co-authored-by: mirka <[email protected]> Co-authored-by: tyxla <[email protected]>
Part of #46741, #63871
What?
Default the QueryControls to the new 40px size.
Why?
Similar to #64456, I think this was one of those components where we didn't need to have a transitional period with the
__next40pxDefaultSizeprop. It is a compound component, similar to ColorPicker or TimePicker, which won't cause serious breakage due to the input fields being upsized. The component won't be used in a context where upsizing the inputs would cause overflows, for example.How?
Remove the prop. The only usage of QueryControls in the app is in the Latest Posts block, which was still using the old size. This is now corrected:
Testing Instructions
Usages of QueryControls should now default to the larger size. Also, having the
__next40pxDefaultSizeprop should not cause TypeScript compilation to fail (only marked as deprecated).