ContentOnly: Add support for block styles on top-level contentOnly locked blocks #64872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +69 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
Mamaduka
reviewed
Aug 28, 2024
Mamaduka
reviewed
Aug 28, 2024
Mamaduka
reviewed
Aug 29, 2024
Mamaduka
approved these changes
Aug 29, 2024
bph
pushed a commit
to bph/gutenberg
that referenced
this pull request
Aug 31, 2024
…cked blocks (WordPress#64872) Co-authored-by: ntsekouras <[email protected]> Co-authored-by: richtabor <[email protected]> Co-authored-by: Mamaduka <[email protected]>
23 tasks
fabiankaegy
added
the
Needs Dev Note
97 tasks
|
Hey @ntsekouras 👋 Would you be able to help write a dev note for this for the 6.7 release? We are planning to have this as part of a larger Miscellaneous Editor Updates note. We are hoping to get all drafts in by October 13th to leave some time for reviews before the RC1. All Dev Notes get tracked in #65784 so feel free to leave a note there or ping me directly :) Please let us know if you can assist with that. Thanks in advance :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Resolves: #64660
This PR adds support for surfacing a parent block's style variations on contentOnly locked groups. This way styles can still be applied cohesively across the group of blocks.
Testing Instructions
contentOnlyin code editor by adding"templateLock": "contentOnly"attribute at the top-level that block.Groupblock.json file: