Zoom Out: Don't pass 'rootClientId' to block lock selectors #64887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Code Quality
Mamaduka
requested review from
ellatrix,
ajitbohra,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
Mamaduka
requested review from
jeryj,
MaggieCabrera and
tyxla
and removed request for
juanmaguitar,
ajitbohra,
ellatrix,
ndiego and
fabiankaegy
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +3 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
Mamaduka
commented
Aug 28, 2024
| canRemove: canRemoveBlock( clientId, rootClientId ), | ||
| canMove: canMoveBlock( clientId, rootClientId ), | ||
| canRemove: canRemoveBlock( clientId ), | ||
| canMove: canMoveBlock( clientId ), |
There was a problem hiding this comment.
I think we can drop the canMove condition. Suffling doesn't change the block's position in the canvas.
Mamaduka
commented
Aug 29, 2024
| @@ -1752,7 +1752,7 @@ export function canRemoveBlocks( state, clientIds ) { | |||
| * @param {Object} state Editor state. | |||
| * @param {string} clientId The block client Id. | |||
| * | |||
| * @return {boolean | undefined} Whether the given block is allowed to be moved. | |||
| * @return {boolean} Whether the given block is allowed to be moved. | |||
There was a problem hiding this comment.
Unrelated; just fixed selector's return type.
ellatrix
approved these changes
Aug 29, 2024
|
Thanks, @ellatrix! |
bph
pushed a commit
to bph/gutenberg
that referenced
this pull request
Aug 31, 2024
…s#64887) Co-authored-by: Mamaduka <[email protected]> Co-authored-by: ellatrix <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This is a follow-up to #60123.
PR updates the
ZoomOutToolbarcomponent and removes therootClientIdpassed to block lock selectors.Why?
The argument is no longer needed after #62547. Prevents prop-drilling the
rootClientId.How?
Testing Instructions
Testing Instructions for Keyboard
Same.
Screenshots or screencast