Build: Prepare build for more script modules #65064
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,133 @@ | ||
| /** | ||
| * External dependencies | ||
| */ | ||
| const { join } = require( 'path' ); | ||
|
|
||
| /** | ||
| * WordPress dependencies | ||
| */ | ||
| const DependencyExtractionWebpackPlugin = require( '@wordpress/dependency-extraction-webpack-plugin' ); | ||
|
|
||
| /** | ||
| * Internal dependencies | ||
| */ | ||
| const { baseConfig, plugins } = require( './shared' ); | ||
|
|
||
| const WORDPRESS_NAMESPACE = '@wordpress/'; | ||
| const { createRequire } = require( 'node:module' ); | ||
|
|
||
| const rootURL = new URL( '..', `file://${ __dirname }` ); | ||
| const fromRootRequire = createRequire( rootURL ); | ||
|
|
||
| /** @type {Iterable<[string, string]>} */ | ||
| const iterableDeps = Object.entries( | ||
| fromRootRequire( './package.json' ).dependencies | ||
| ); | ||
|
|
||
| /** @type {Map<string, string>} */ | ||
| const gutenbergScriptModules = new Map(); | ||
| for ( const [ packageName, versionSpecifier ] of iterableDeps ) { | ||
| if ( | ||
| ! packageName.startsWith( WORDPRESS_NAMESPACE ) || | ||
| ! versionSpecifier.startsWith( 'file:' ) || | ||
| packageName.startsWith( WORDPRESS_NAMESPACE + 'react-native' ) | ||
| ) { | ||
| continue; | ||
| } | ||
|
|
||
| const packageRequire = createRequire( | ||
| // Remove the leading "file:" specifier to build a package URL. | ||
| new URL( `${ versionSpecifier.substring( 5 ) }/`, rootURL ) | ||
| ); | ||
|
|
||
| const depPackageJson = packageRequire( './package.json' ); | ||
| if ( ! Object.hasOwn( depPackageJson, 'wpScriptModuleExports' ) ) { | ||
| continue; | ||
| } | ||
|
|
||
| const moduleName = packageName.substring( WORDPRESS_NAMESPACE.length ); | ||
| let { wpScriptModuleExports } = depPackageJson; | ||
|
|
||
| // Special handling for { "wpScriptModuleExports": "./build-module/index.js" }. | ||
| if ( typeof wpScriptModuleExports === 'string' ) { | ||
| wpScriptModuleExports = { '.': wpScriptModuleExports }; | ||
| } | ||
|
|
||
| if ( Object.getPrototypeOf( wpScriptModuleExports ) !== Object.prototype ) { | ||
| throw new Error( 'wpScriptModuleExports must be an object' ); | ||
| } | ||
|
|
||
| for ( const [ exportName, exportPath ] of Object.entries( | ||
| wpScriptModuleExports | ||
| ) ) { | ||
| if ( typeof exportPath !== 'string' ) { | ||
| throw new Error( 'wpScriptModuleExports paths must be strings' ); | ||
| } | ||
|
|
||
| if ( ! exportPath.startsWith( './' ) ) { | ||
| throw new Error( | ||
| 'wpScriptModuleExports paths must start with "./"' | ||
| ); | ||
| } | ||
|
|
||
| const name = | ||
| exportName === '.' ? 'index' : exportName.replace( /^\.\/?/, '' ); | ||
|
|
||
| gutenbergScriptModules.set( | ||
| `${ moduleName }/${ name }`, | ||
| packageRequire.resolve( exportPath ) | ||
| ); | ||
| } | ||
| } | ||
|
|
||
| module.exports = { | ||
| ...baseConfig, | ||
| name: 'script-modules', | ||
| entry: Object.fromEntries( gutenbergScriptModules.entries() ), | ||
| experiments: { | ||
| outputModule: true, | ||
| }, | ||
| output: { | ||
| devtoolNamespace: 'wp', | ||
| filename: './build-module/[name].min.js', | ||
| library: { | ||
| type: 'module', | ||
| }, | ||
| path: join( __dirname, '..', '..' ), | ||
| environment: { module: true }, | ||
| module: true, | ||
| chunkFormat: 'module', | ||
| asyncChunks: false, | ||
| }, | ||
| resolve: { | ||
| extensions: [ '.js', '.ts', '.tsx' ], | ||
| }, | ||
| module: { | ||
| rules: [ | ||
| { | ||
| test: /\.(j|t)sx?$/, | ||
| exclude: /node_modules/, | ||
| use: [ | ||
| { | ||
| loader: require.resolve( 'babel-loader' ), | ||
| options: { | ||
| cacheDirectory: | ||
| process.env.BABEL_CACHE_DIRECTORY || true, | ||
| babelrc: false, | ||
| configFile: false, | ||
| presets: [ | ||
| '@babel/preset-typescript', | ||
| '@babel/preset-react', | ||
| ], | ||
| }, | ||
| }, | ||
| ], | ||
| }, | ||
| ], | ||
| }, | ||
| plugins: [ ...plugins, new DependencyExtractionWebpackPlugin() ], | ||
| watchOptions: { | ||
| ignored: [ '**/node_modules' ], | ||
| aggregateTimeout: 500, | ||
| }, | ||
| }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't remember why there was pattern matching used for files in the
buildfolder. @youknowriad, is there anything important we might miss when including the entirebuild-module? At the moment, we want all files to be included from there.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created related PR #65064