-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Add build-module to unit test assets #65499
Conversation
e301514
to
a9a3825
Compare
Flaky tests detected in a9a3825. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/10948606263
|
a9a3825
to
487a982
Compare
Why do I see these test failures here?
|
Ok, this has fixed things. You can see PHP tests passing in #65460 now (with this merged). |
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
I've aded the backport label. This won't affect the plugin at all but it could cause problems on CI on branches if this is not fixed. |
path: | | ||
./build/ | ||
./build-module/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here we need to list all the paths.
If multiple paths are provided as input, the least common ancestor of all the search paths will be used as the root directory of the artifact. Exclude paths do not affect the directory structure.
@@ -212,7 +214,6 @@ jobs: | |||
uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 # v4.1.8 | |||
with: | |||
name: build-assets | |||
path: ./build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here we remove the path so that it extracts all the assets correctly instead of naming them.
Before, since there was one directory in the aftifact, naming it build
was OK. Now that we have a parent directory with build
and build-module
it just goes into the working directory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with the linked PR and the changes make sense 👍🏻
What?
build-module
was not included in the built unit test assets which can cause test failures.This was overlooked in #65064.
This is a fix extracted from #65460.
Why?
The compiled assets are cached and shared across unit tests. This applies to both
build
andbuild-module
directories.Testing Instructions
CI passes. Also review CI on #65460.