Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zoom layout shift: Alternate fix. #65967

Closed
wants to merge 3 commits into from
+4 −0
Closed

Zoom layout shift: Alternate fix. #65967

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
786f8c9
Zoom layout shift: Alternate fix.
jasmussen Oct 9, 2024
231d06f
Add body tag nesting
andrewserong Oct 10, 2024
79b8fe3
Try additional rule
andrewserong Oct 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/block-editor/src/components/iframe/content.scss
View file
Original file line number Diff line number Diff line change
@@ -25,6 +25,10 @@
border: 0 solid $gray-300;
transform-origin: top center;
@include editor-canvas-resize-animation;

// Applying flex here prevents the body element, and title inside, from margin-collapse.
display: flex;
flex-direction: column;
}

.block-editor-iframe__html.is-zoomed-out {

Unchanged files with check annotations Beta

View file
packages/e2e-test-utils-playwright/src/request-utils/rest.ts
const url = this.storageState!.rootURL + relativePath;
try {
const response = await this.request.fetch( url, {

Check failure on line 119 in packages/e2e-test-utils-playwright/src/request-utils/rest.ts

GitHub Actions / Playwright - 6

[chromium] › widgets/customizing-widgets.spec.js:236:2 › Widgets Customizer › should move focus to the block 

  1) [chromium] › widgets/customizing-widgets.spec.js:236:2 › Widgets Customizer › should move focus to the block 
    Error: apiRequestContext.fetch: socket hang up
    Call log:
      - → GET http://localhost:8889/index.php?rest_route=/wp/v2/sidebars
      -   user-agent: Playwright/1.47.0 (x64; ubuntu 22.04) node/20.18 CI/1
      -   accept: */*
      -   accept-encoding: gzip,deflate,br
      -   X-WP-Nonce: 6444315a40
      -   cookie: wordpress_test_cookie=WP%20Cookie%20check; wordpress_logged_in_23778236db82f19306f247e20a353a99=admin%7C1728779412%7C8rLCSFVypotoGN8Sj4457K3UTFfhEG483Ua5iYFWWzC%7C52c7ceb850974eccd9d818cf04e655091d782d54ff4951b1f86e84ddcc7e74ba; wp-settings-time-1=1728606906


       at ../../../packages/e2e-test-utils-playwright/src/request-utils/rest.ts:119

      117 |
      118 | 	try {
    > 119 | 		const response = await this.request.fetch( url, {
          | 		                                    ^
      120 | 			...fetchOptions,
      121 | 			failOnStatusCode: false,
      122 | 			headers: {

        at RequestUtils.rest (/home/runner/work/gutenberg/gutenberg/packages/e2e-test-utils-playwright/src/request-utils/rest.ts:119:39)
        at RequestUtils.deleteAllWidgets (/home/runner/work/gutenberg/gutenberg/packages/e2e-test-utils-playwright/src/request-utils/widgets.js:9:8)
        at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/widgets/customizing-widgets.spec.js:37:22
...fetchOptions,
failOnStatusCode: false,
headers: {