Editor: Use plugin context hook in 'PluginPreviewMenuItem' #66350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
commented
Oct 23, 2024
| @@ -27,12 +26,12 @@ import { ActionItem } from '@wordpress/interface'; | |||
| * } | |||
| * | |||
| * const ExternalPreviewMenuItem = () => ( | |||
| * <PreviewDropdownMenuItem | |||
| * <PluginPreviewMenuItem | |||
There was a problem hiding this comment.
Fixes a typo in the original example.
|
Size Change: +34 B (0%) Total Size: 1.81 MB
ℹ️ View Unchanged
|
|
Context why I started working on this "out of the blue" 😄 - #66351 (comment). |
youknowriad
approved these changes
Oct 23, 2024
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
…#66350) Co-authored-by: Mamaduka <[email protected]> Co-authored-by: youknowriad <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This is a follow-up to #64644.
Similar to #53302.
PR updates the new
PluginPreviewMenuItemcomponent to use theusePluginContexthook instead of HOC.Why?
Using the context hook should be preferred over HOC.
Testing Instructions
The feature also has e2e test coverage.
Test snippet
Testing Instructions for Keyboard
Same.
Screenshots or screencast