Fix: Show Meta Boxes at the bottom of the screen regardless of the current rendering mode #66508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiankaegy
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +15 B (0%) Total Size: 1.81 MB
ℹ️ View Unchanged
|
fabiankaegy
force-pushed
the
fix/allow-metaboxes-to-remain-visible-in-template-locked-rendering-mode
branch
from
4bea2ca to
c5f4345
Compare
|
This was introduced in #65885. |
|
@Mamaduka I think the PR you share is unrelated. I'm not talking about the additional padding appender at the bottom but rather the metaboxes area which was refactored in the 6.7 cycle but already in 6.6 using the preview template hid the metaboxes. So this is not a new regression. |
Mamaduka
reviewed
Oct 29, 2024
| @@ -426,7 +428,7 @@ function Layout( { | |||
| isDistractionFree: get( 'core', 'distractionFree' ), | |||
| showMetaBoxes: | |||
| ! DESIGN_POST_TYPES.includes( currentPostType ) && | |||
| isRenderingPostOnly, | |||
| ( isRenderingPostOnly || isRenderingTemplateLocked ), | |||
There was a problem hiding this comment.
Can you refresh my memory here? Do we have rendering modes besides post-only and template-locked?
If not, then I think we can remove rendering mode checks from this condition.
There was a problem hiding this comment.
I am not a 100% certain but I thought that the "edit template" portion in the post editor technically uses template-only as the rendering mode 🤔
@youknowriad may be able to help clarify this though :)
There was a problem hiding this comment.
Judging from the comment of the setRenderingMode action, there should be no modes other than post-only and template-locked. The template-only mode has been removed in #57700. I've tried searching Gutenberg in general for getRenderingMode() or setRenderingMode(, but I can't find any other modes.
Therefore, I think this check should be removable, but I will ping @stokesman to double check.
There was a problem hiding this comment.
Removing it looks safe to me. I quickly checked with "edit template" and its rendering mode is "post-only". The condition that matters in that case is the post type being "wp_template" so it will still not show the meta boxes.
There was a problem hiding this comment.
Thanks all! I just updated the code to remove the check entirely 👍 :)
stokesman
approved these changes
Oct 29, 2024
fabiankaegy
changed the title
template-locked rendering mode
fabiankaegy
force-pushed
the
fix/allow-metaboxes-to-remain-visible-in-template-locked-rendering-mode
branch
from
58c58d0 to
352983e
Compare
fabiankaegy
deleted the
fix/allow-metaboxes-to-remain-visible-in-template-locked-rendering-mode
branch
|
@youknowriad @ndiego @annezazu Wondering if we could consider this a fix we want to get into 6.7.1? With the new meta box styling here and more usage of the template preview this issue is much more prevalent in 6.7 than it was before 🤔 |
youknowriad
added
the
Backport to WP Minor Release
|
Let's give it a try. I added the flag. Not sure who's going to be leading that release though |
|
Agreed with Riad. Thanks for flagging this, Fabian! |
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
…rrent rendering mode (WordPress#66508) Co-authored-by: fabiankaegy <[email protected]> Co-authored-by: Mamaduka <[email protected]> Co-authored-by: t-hamano <[email protected]> Co-authored-by: stokesman <[email protected]>
|
Backported to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
allow metaboxes to remain visible in
template-lockedrendering mode (closing #66507)Why?
Because in the
template-lockedrendering mode you are actively still editing a post. So any metaboxes should still be available. They should only disappear in thetemplate-onlymode.How?
By adding an additional check if the mode is either
post-onlyortemplate-lockedTesting Instructions
template-lockedmode