Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent jumping of search button #66929

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

sarthaknagoshe2002
Copy link
Contributor

@sarthaknagoshe2002 sarthaknagoshe2002 commented Nov 12, 2024

Fixes: #52854

What?

When the search box has change button position set to button only and is aligned to the right while having blocks to it left, the search button jumps, highlighted in #52854.
This PR fixes this jumping of search button when the search box expands.

How?

Removed flex-basis property from the input box which was making the button jump.

Testing Instructions

  1. Add/edit existing post.
  2. Add a row.
  3. Add some blocks on the left side of the row.
  4. Add the search block to the right.
  5. Set change button position to button only.
  6. On the frontend the search button should no longer jump while expanding the search box.

Screenshots or screencast

Before

Screen.Recording.2024-11-12.at.5.30.57.PM.mov

After

Screen.Recording.2024-11-12.at.5.31.25.PM.mov

Copy link

github-actions bot commented Nov 12, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: sarthaknagoshe2002 <[email protected]>
Co-authored-by: skorasaurus <[email protected]>
Co-authored-by: hanneslsm <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Nov 12, 2024
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @sarthaknagoshe2002! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@akasunil akasunil added [Type] Bug An existing feature does not function as intended [Block] Search Affects the Search Block - used to display a search field labels Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Search Affects the Search Block - used to display a search field First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search: Button only: Button position jumps on transition
2 participants