-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Video Block: refactor setting panel #67044
base: trunk
Are you sure you want to change the base?
Video Block: refactor setting panel #67044
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for spinning up this PR @up1512001 🚀
Before we commit to refactoring the panel. As @t-hamano has proposed on your original PR, it would be good to see what's involved in the block support approach first.
My understanding of your original PR was that your use case needed an additional option (contain?) that the existing aspect ratio block support didn't provide? Can you give #67047 a test and review to see if it does meet your needs?
Even if we choose to adopt the block support instead of #66946, this refactor of the panel might still be desirable to bring the block inline with the Cover and Image blocks. We can make that call later though once we get the functionality we want.
What?
Splitting from #66946
Why?
While adding
DimensionsTool
to video block it appears it needs to be insideToolsPanel
component instead ofPanelBody
.Testing Instructions
Screenshots or screencast
Screen.Recording.2024-11-16.at.00.11.32.mov