Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storybook : Add TextTransformControl stories #67365

Merged
merged 5 commits into from
Dec 20, 2024

Conversation

im3dabasia
Copy link
Contributor

@im3dabasia im3dabasia commented Nov 28, 2024

Part of #67165

What?

This PR will add stories for TextTransformControl component in the Storybook.

Testing Instructions

  1. Run npm run storybook:dev
  2. Open the storybook on http://localhost:50240/
  3. Check the TextTransformControl stories.

Screen shot

image

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Nov 28, 2024
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @im3dabasia! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

Copy link

github-actions bot commented Nov 28, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: im3dabasia <[email protected]>
Co-authored-by: t-hamano <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@miminari miminari requested review from mirka and t-hamano November 29, 2024 00:14
@t-hamano t-hamano added [Type] Developer Documentation Documentation for developers Storybook Storybook and its stories for components labels Dec 8, 2024
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

I would like to make two suggestions.

  • It looks like you are adding as many variations as possible as individual stories, but this seems redundant. All these props can be changed from the Controls panel. Also, if we go ahead with this approach, we will probably add similar variations to all other block editor components 😅
  • It is certainly easier to understand with demo text, but Storybook is for testing and developing a single component itself. How this component interacts with the outside world is the responsibility of the developer who uses this component, and I think it is better not to include it in the story.

With that in mind, I think it would be best to focus on just improving argTypes in this PR. What do you think?

@im3dabasia
Copy link
Contributor Author

Hey @t-hamano,

thanks for your feedback. I have tried incorporating all the feedback you shared in this PR and the issue. Please take a look at my updated work and provide feedback

@im3dabasia im3dabasia requested a review from t-hamano December 12, 2024 15:45
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I have a few small suggestions, but overall it looks good 👍

@im3dabasia im3dabasia force-pushed the storybook/text-transform-control branch from 6e052fb to 236dc2c Compare December 19, 2024 07:28
@im3dabasia
Copy link
Contributor Author

Hey @t-hamano ,

I have made the changes based on your suggestions. I am attaching a screencast for the same. Please provide feedback on my work.

Screen.Recording.2024-12-19.at.1.32.16.PM.mov

@im3dabasia im3dabasia requested a review from t-hamano December 19, 2024 08:05
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update! Sorry, there was a mistake in my previous suggestion🙇‍♂️

@im3dabasia im3dabasia requested a review from t-hamano December 19, 2024 10:22
@im3dabasia
Copy link
Contributor Author

im3dabasia commented Dec 20, 2024

Hey @t-hamano, could you please have a look at this PR? I have incorporated all the feedback you suggested.

Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!

One last thing, could you fix a mistake in the README? The default value for the value prop is undefined, not "none", so we'll need to remove this line:

@im3dabasia
Copy link
Contributor Author

im3dabasia commented Dec 20, 2024

One last thing, could you fix a mistake in the README? The default value for the value prop is undefined, not "none", so we'll need to remove this line:

Done @t-hamano , I have removed this line.

Thank you very much for the review.

@im3dabasia im3dabasia requested a review from t-hamano December 20, 2024 07:49
@t-hamano t-hamano merged commit 76d4652 into WordPress:trunk Dec 20, 2024
62 checks passed
@github-actions github-actions bot added this to the Gutenberg 20.0 milestone Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository Storybook Storybook and its stories for components [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants