Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Featured Image Block: Refactor setting panel #67456

Merged
merged 2 commits into from
Dec 14, 2024
+67 −10
Merged

Featured Image Block: Refactor setting panel #67456

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8730f1f
Refactor setting panel of featured image block control
akasunil Dec 2, 2024
6a81c61
Fix link target attribute reset
akasunil Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
77 changes: 67 additions & 10 deletions packages/block-library/src/post-featured-image/edit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,12 @@ import { useEntityProp, store as coreStore } from '@wordpress/core-data';
import { useSelect, useDispatch } from '@wordpress/data';
import {
ToggleControl,
PanelBody,
Placeholder,
Button,
Spinner,
TextControl,
__experimentalToolsPanel as ToolsPanel,
__experimentalToolsPanelItem as ToolsPanelItem,
} from '@wordpress/components';
import {
InspectorControls,
Expand All @@ -38,6 +39,7 @@ import { store as noticesStore } from '@wordpress/notices';
import DimensionControls from './dimension-controls';
import OverlayControls from './overlay-controls';
import Overlay from './overlay';
import { useToolsPanelDropdownMenuProps } from '../utils/hooks';

const ALLOWED_MEDIA_TYPES = [ 'image' ];

Expand Down Expand Up @@ -183,6 +185,8 @@ export default function PostFeaturedImageEdit( {
setTemporaryURL();
};

const dropdownMenuProps = useToolsPanelDropdownMenuProps();

const controls = blockEditingMode === 'default' && (
<>
<InspectorControls group="color">
Expand All @@ -201,9 +205,18 @@ export default function PostFeaturedImageEdit( {
/>
</InspectorControls>
<InspectorControls>
<PanelBody title={ __( 'Settings' ) }>
<ToggleControl
__nextHasNoMarginBottom
<ToolsPanel
label={ __( 'Settings' ) }
resetAll={ () => {
setAttributes( {
isLink: false,
linkTarget: '_self',
rel: '',
} );
} }
dropdownMenuProps={ dropdownMenuProps }
>
<ToolsPanelItem
label={
postType?.labels.singular_name
? sprintf(
Expand All @@ -213,11 +226,42 @@ export default function PostFeaturedImageEdit( {
)
: __( 'Link to post' )
}
onChange={ () => setAttributes( { isLink: ! isLink } ) }
checked={ isLink }
/>
isShownByDefault
hasValue={ () => !! isLink }
onDeselect={ () =>
setAttributes( {
isLink: false,
} )
}
>
<ToggleControl
__nextHasNoMarginBottom
label={
postType?.labels.singular_name
? sprintf(
// translators: %s: Name of the post type e.g: "post".
__( 'Link to %s' ),
postType.labels.singular_name
)
: __( 'Link to post' )
}
onChange={ () =>
setAttributes( { isLink: ! isLink } )
}
checked={ isLink }
/>
</ToolsPanelItem>
{ isLink && (
<>
<ToolsPanelItem
label={ __( 'Open in new tab' ) }
isShownByDefault
hasValue={ () => '_self' !== linkTarget }
onDeselect={ () =>
setAttributes( {
linkTarget: '_self',
} )
}
>
<ToggleControl
__nextHasNoMarginBottom
label={ __( 'Open in new tab' ) }
Expand All @@ -228,6 +272,19 @@ export default function PostFeaturedImageEdit( {
}
checked={ linkTarget === '_blank' }
/>
</ToolsPanelItem>
) }
{ isLink && (
<ToolsPanelItem
label={ __( 'Link rel' ) }
isShownByDefault
hasValue={ () => !! rel }
onDeselect={ () =>
setAttributes( {
rel: '',
} )
}
>
<TextControl
__next40pxDefaultSize
__nextHasNoMarginBottom
Expand All @@ -237,9 +294,9 @@ export default function PostFeaturedImageEdit( {
setAttributes( { rel: newRel } )
}
/>
</>
</ToolsPanelItem>
) }
</PanelBody>
</ToolsPanel>
</InspectorControls>
</>
);
Expand Down
Loading