Site Title Block: Refactor settings panel to use ToolsPanel #67898
Conversation
fabiankaegy
added
[Type] Enhancement
|
@Sukhendu2002 there is a Unit Test that needs to be updated here |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
@fabiankaegy I believe the issue was with a GitHub Action. I reran the tests, and they all passed. |
…ad of PanelBody (WordPress#67898) Co-authored-by: Sukhendu2002 <[email protected]> Co-authored-by: fabiankaegy <[email protected]>
…ad of PanelBody (WordPress#67898) Co-authored-by: Sukhendu2002 <[email protected]> Co-authored-by: fabiankaegy <[email protected]>
| } } | ||
| > | ||
| <ToolsPanelItem | ||
| hasValue={ () => isLink !== false } |
There was a problem hiding this comment.
The default value for isLink is true, so having a value means that the value is false.
Therefore, the boolean value here should be reversed, or this setting won't reset properly.
Part of: #67813
What?
Refactored Site Title Block code to include ToolsPanel instead of PanelBody.
Screenshots or screencast