Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor "Settings" panel of Navigation Item block to use ToolsPanel instead of PanelBody #67973

Merged
merged 6 commits into from
Dec 19, 2024
Merged

Refactor "Settings" panel of Navigation Item block to use ToolsPanel instead of PanelBody #67973

merged 6 commits into from
Dec 19, 2024

Conversation

rinkalpagdar
Copy link
Contributor

@rinkalpagdar rinkalpagdar commented Dec 13, 2024 •
edited
Loading

Part of #67813
Fixes #67947

Testing Instructions

  • Add navigation block
  • Click on the item link
  • Open the settings panel

Screenshots or screencast

Before After
before-toolspanel after-toolspanel

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 13, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: rinkalpagdar <[email protected]>
Co-authored-by: fabiankaegy <[email protected]>
Co-authored-by: getdave <[email protected]>
Co-authored-by: Mamaduka <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@fabiankaegy fabiankaegy added [Type] Enhancement A suggestion for improvement. [Block] Navigation Link Affects the Navigation Link Block labels Dec 13, 2024
@fabiankaegy
Copy link
Member

@rinkalpagdar Looks like the Linting GitHub Action Check is failing. Would you mind addressing that? :)

@Mamaduka
Copy link
Member

I see package-lock.json and linting changes unrelated to this refactoring.

See contribution guidelines for developer tool setup - https://developer.wordpress.org/block-editor/contributors/code/getting-started-with-code-contribution/#developer-tools.

fabiankaegy
fabiankaegy requested changes Dec 13, 2024
View reviewed changes
Copy link
Member

@fabiankaegy fabiankaegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the linting there are some additional notes here:

In this initial refactor we need to make sure that all settings that were present before this update are still always visible after the update. So every ToolsPanelItem needs to have isShownByDefault set on it

CleanShot.2024-12-13.at.15.48.48.mp4

package-lock.json Outdated Show resolved Hide resolved
getdave
getdave reviewed Dec 16, 2024
View reviewed changes
Copy link
Contributor

@getdave getdave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for tackling this.

I wonder if you'd be able to revise the PR to remove the whitespace changes as it's making it quite challenging to review.

Much appreciated.

packages/block-library/src/navigation-link/edit.js Outdated
Comment on lines 64 to 65
handleDragEnter( event );
handleDragEnter(event);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we please remove all the whitespace changes in this PR? 🙏

It would make it a lot easier to review. Many thanks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @getdave I have removed all whitespace changes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rinkalpagdar, unfortunately, linting errors remain. I would recommend setting up ESLint + Prettier and letting the editor handle stylistic fixes for you.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These now look fixed to me thank you.

getdave
getdave reviewed Dec 17, 2024
View reviewed changes
Copy link
Contributor

@getdave getdave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your continued work on this.

@fabiankaegy I just tested and the settings look the same and are set to display in the same way they were previously. Tests pass with is encouraging.

I would suggest an additional confidence check from @fabiankaegy @Mamaduka and perhaps @draganescu?

fabiankaegy
fabiankaegy approved these changes Dec 19, 2024
View reviewed changes
Copy link
Member

@fabiankaegy fabiankaegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for much for working on this! This works as expected :)

@fabiankaegy fabiankaegy merged commit afca7b5 into WordPress:trunk Dec 19, 2024
64 checks passed
@github-actions github-actions bot added this to the Gutenberg 20.0 milestone Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@getdave getdave getdave left review comments

@fabiankaegy fabiankaegy fabiankaegy approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@Mamaduka Mamaduka Awaiting requested review from Mamaduka

Assignees

@rinkalpagdar rinkalpagdar

Labels
[Block] Navigation Link Affects the Navigation Link Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
Gutenberg 20.0
Development

Successfully merging this pull request may close these issues.

Refactor "Settings" panel of Navigation Item block to use ToolsPanel instead of PanelBody
4 participants
@rinkalpagdar @fabiankaegy @Mamaduka @getdave