Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List: Add Layout Support #68002

Open
wants to merge 5 commits into
base: trunk
Choose a base branch
from
Open

List: Add Layout Support #68002

wants to merge 5 commits into from

Conversation

shail-mehta
Copy link
Member

@shail-mehta shail-mehta commented Dec 15, 2024

What?

Added Layout support and also added Align Wide and full width support to the List block.

Part of : #43248

Why?

The block was missing Layout Support and Align Support (Wide and Full Width) Support Features.

Testing Instructions

  • Add List Block in Page / Post.
  • Select and align wide or full width
  • Also Check With layout width in Layout Settings
  • Check Settings in Editor and Frontend Side

Screenshots or Screencast

List-layout-support.mp4

@shail-mehta shail-mehta self-assigned this Dec 15, 2024
@shail-mehta shail-mehta added [Type] Enhancement A suggestion for improvement. [Block] List Affects the List Block labels Dec 15, 2024
Copy link

github-actions bot commented Dec 15, 2024

Flaky tests detected in 3ab53a2.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12446088230
📝 Reported issues:

@shail-mehta shail-mehta marked this pull request as ready for review December 15, 2024 10:02
Copy link

github-actions bot commented Dec 15, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: shail-mehta <[email protected]>
Co-authored-by: aaronrobertshaw <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Contributor

@aaronrobertshaw aaronrobertshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @shail-mehta 👍

Could you please add some further details to the PR description and test instructions?

I'm not sure exactly what needs to be tested here or the reasoning behind the layout configuration chosen. Also, tweaking the PR title to match what is happening in the code changes is always good (i.e. adding align and layout support).

@@ -38,6 +38,8 @@
},
"supports": {
"anchor": true,
"align": [ "wide", "full" ],
"__experimentalLayout": true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe __experimentalLayout was stabilized to layout back in June 2023 via #51434.

@shail-mehta
Copy link
Member Author

Thanks for the Feedback. I will work on this.

@shail-mehta shail-mehta force-pushed the add/list-layout-support branch from 9318cc2 to 1ec53cf Compare December 21, 2024 14:18
@shail-mehta
Copy link
Member Author

@aaronrobertshaw I have Used layout instead of __experimentalLayout and also added testing instructions in description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] List Affects the List Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants