-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List: Add Layout Support #68002
base: trunk
Are you sure you want to change the base?
List: Add Layout Support #68002
Conversation
Flaky tests detected in 3ab53a2. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12446088230
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @shail-mehta 👍
Could you please add some further details to the PR description and test instructions?
I'm not sure exactly what needs to be tested here or the reasoning behind the layout configuration chosen. Also, tweaking the PR title to match what is happening in the code changes is always good (i.e. adding align and layout support).
@@ -38,6 +38,8 @@ | |||
}, | |||
"supports": { | |||
"anchor": true, | |||
"align": [ "wide", "full" ], | |||
"__experimentalLayout": true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe __experimentalLayout
was stabilized to layout
back in June 2023 via #51434.
Thanks for the Feedback. I will work on this. |
9318cc2
to
1ec53cf
Compare
@aaronrobertshaw I have Used |
What?
Added Layout support and also added Align Wide and full width support to the List block.
Part of : #43248
Why?
The block was missing Layout Support and Align Support (Wide and Full Width) Support Features.
Testing Instructions
Screenshots or Screencast
List-layout-support.mp4