-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Date Block: Add dropdown menu props to ToolsPanel component #68018
base: trunk
Are you sure you want to change the base?
Date Block: Add dropdown menu props to ToolsPanel component #68018
Conversation
Hi @fabiankaegy, This PR follows up on adding dropdown menu props to the ToolsPanel. The initial changes have already been merged. |
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
@Sukhendu2002 It looks like #67906 also introduced some issue with the spacing here: BeforeAfterThe text 'Choose a format' is very close to the example text. Is that something you'd be able to fix in this PR as well? |
Hi @talldan, Good catch! Thanks for pointing that out. I'm already looking into it and will include a fix for the spacing issue in this PR as well. 😊 |
packages/block-editor/src/components/block-inspector/style.scss
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing the requested changes!
@Sukhendu2002 It looks like @t-hamano has recently fixed the styling issues in a separate PR that's been merged - #68079. 😄 Looks like you're already on top of it with a couple of recent commits. |
Yes, I think just adding the |
@talldan I've removed the unnecessary CSS. Feel free to take a look when you have a moment! |
Follow up of: #67906
What?
Enhances the Date block's ToolsPanel by adding support for dropdown menu functionality through the useToolsPanelDropdownMenuProps hook.
Screenshots or screencast