Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date Block: Add dropdown menu props to ToolsPanel component #68018

Open
wants to merge 6 commits into
base: trunk
Choose a base branch
from

Conversation

Sukhendu2002
Copy link
Contributor

Follow up of: #67906

What?

Enhances the Date block's ToolsPanel by adding support for dropdown menu functionality through the useToolsPanelDropdownMenuProps hook.

Screenshots or screencast

Before After
image image

@Sukhendu2002 Sukhendu2002 marked this pull request as ready for review December 16, 2024 10:39
@Sukhendu2002
Copy link
Contributor Author

Hi @fabiankaegy, This PR follows up on adding dropdown menu props to the ToolsPanel. The initial changes have already been merged.

Copy link

github-actions bot commented Dec 16, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Sukhendu2002 <[email protected]>
Co-authored-by: talldan <[email protected]>
Co-authored-by: t-hamano <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@fabiankaegy fabiankaegy added [Type] Enhancement A suggestion for improvement. [Block] Post Date Affects the Post Date Block labels Dec 16, 2024
@talldan
Copy link
Contributor

talldan commented Dec 17, 2024

@Sukhendu2002 It looks like #67906 also introduced some issue with the spacing here:

Before

Screenshot 2024-12-17 at 11 17 12 am

After

Screenshot 2024-12-17 at 11 20 20 am

The text 'Choose a format' is very close to the example text.

Is that something you'd be able to fix in this PR as well?

@Sukhendu2002
Copy link
Contributor Author

Hi @talldan, Good catch! Thanks for pointing that out. I'm already looking into it and will include a fix for the spacing issue in this PR as well. 😊

Copy link
Contributor

@talldan talldan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the requested changes!

@talldan
Copy link
Contributor

talldan commented Dec 20, 2024

@Sukhendu2002 It looks like @t-hamano has recently fixed the styling issues in a separate PR that's been merged - #68079. 😄

Looks like you're already on top of it with a couple of recent commits.

@t-hamano
Copy link
Contributor

Yes, I think just adding the dropdownMenuProps hook should be enough for this PR. You may want to retest after rebasing this PR.

@talldan
Copy link
Contributor

talldan commented Dec 20, 2024

Looks like the spacing is too big now, so I agree, the CSS changes in this PR can be removed again 😄
Screenshot 2024-12-20 at 4 36 17 pm

@Sukhendu2002
Copy link
Contributor Author

Thanks for pointing that out, @t-hamano and @talldan! 😊 I’ll rebase the PR and remove the CSS changes.

@Sukhendu2002
Copy link
Contributor Author

@talldan I've removed the unnecessary CSS. Feel free to take a look when you have a moment!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Post Date Affects the Post Date Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants