-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance template registration e2e tests to handle welcome dialog visibility #68059
Enhance template registration e2e tests to handle welcome dialog visibility #68059
Conversation
…bility Added logic to check for the visibility of the "Welcome to the editor" dialog within 2 seconds before attempting to close it.
Size Change: 0 B Total Size: 1.84 MB ℹ️ View Unchanged
|
Flaky tests detected in c1fbf5a. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12393997135
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
…d remove the updates to the second test
@michalczaplinski, let's also swap |
…de registered templates`e2e test
makes sense, done @Mamaduka |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the follow-ups, @michalczaplinski!
What?
In the e2e test for template registration, take into account that the
Welcome to the editor
dialog might be either open or closed.Why?
In another PR #67289 I found some e2e test failures related to this.
We should check if the
Welcome to the editor
dialog is actually open before attempting to close it.How?
admin.createNewPost();
to create posts instead which internally handles closing the dialog.Testing Instructions
This only updates e2e tests, CI check should be sufficient
Screenshots or screencast