Page List Block: Fix critical error when converting to link #68076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
approved these changes
Dec 18, 2024
|
Size Change: +5 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
|
@Mamaduka Thanks for the review! |
Better yet, in this instance, we could not wrap this button in the Making the button always show by default and not ever have a value to be reset makes it completely pointless for it to appear in the tools panel menu. There's a quick and dirty hack (including a diff) over in this comment that explains more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporary fix for #67932 (comment)
What?
To prevent a critical error, add a
hasValueprop to theToolsPanelItemcomponent that always returnsfalse.Why?
In the case that this PR is trying to fix, only the "Edit" button is rendered, and it has no value. So, while ideally the
hasValueprop itself wouldn't be necessary, this prop is required and will throw a critical error if it's missing.How?
Add a
hasValueprop that always returnsfalseto prevent a critical error. Ideally, I think theToolsPanelItemshould be modified to correctly handle items that have no value (See this comment).If this PR approach is not ideal, we may need to revert #67903 for now.
Testing Instructions
Screenshot