Query Pagination: Update 'showLabel' help text #68105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
fabiankaegy
approved these changes
Dec 18, 2024
| help={ __( | ||
| 'Toggle off to hide the label text, e.g. "Next Page".' | ||
| ) } | ||
| help={ __( 'Make label text visible to the users.' ) } |
There was a problem hiding this comment.
I like that you remove the CTA from this. Makes it align better with all other instances.
But I have to say I do think the example was useful to know what the label text is actually referring to
There was a problem hiding this comment.
I like that you remove the CTA from this. Makes it align better with all other instances.
CTAs doesn't make sense for similar UI controls.
But I have to say I do think the example was useful to know what the label text is actually referring to
I don't have a strong opinion on the example, happy to append it back. But here's why I removed it:
- This is parent-controlling child blocks, so it's a half example.
- What if you've changed the label to something very different? Would the example still make sense?
|
Size Change: -3 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in b4dfe27. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12410389716
|
|
I'd welcome this improvement, thanks for working on this @Mamaduka The main point on the issue is that the UI doesn't show the labeling of the previous/next any longer when the setting is switched to 'arrows'. As such:
At this point, users may completely forget they previously entered inappropriate labels text and the UI doesn't expose the labels text in any way. This PR improves the help text in the UI but I'd like to avoid it closes #51335 when merged because the reported issue isn't solved yet. Can we change the |
afercia
reviewed
Dec 19, 2024
| help={ __( | ||
| 'Toggle off to hide the label text, e.g. "Next Page".' | ||
| ) } | ||
| help={ __( 'Make label text visible to the users.' ) } |
There was a problem hiding this comment.
isn't to the users implied?
afercia
approved these changes
Dec 19, 2024
swissspidy
reviewed
Dec 19, 2024
packages/block-library/src/query-pagination/query-pagination-label-control.js
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #51335.
PR updates Query Pagination block's
'showLabelattribute helps text. The project eliminates thetogglekeyword from labels and help texts. See #66369.I've also removed the example from a string. The results of toggling to options are visible in the Canvas.
Testing Instructions
Testing Instructions for Keyboard
Same.
Screenshots or screencast