Badge: Support text truncation #68107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirka
added
[Type] Enhancement
|
Size Change: +101 B (+0.01%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 3c03080. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12581388791
|
tyxla
reviewed
Dec 19, 2024
ciampo
reviewed
Dec 19, 2024
| line-height: $font-line-height-small; | ||
| width: fit-content; | ||
| display: flex; | ||
| display: inline-flex; |
There was a problem hiding this comment.
An inline outer display value seems more appropriate ✅
mirka
commented
Jan 2, 2025
|
|
||
| describe( 'Badge', () => { | ||
| it( 'should render correctly with default props', () => { | ||
| render( <Badge>Code is Poetry</Badge> ); | ||
| const badge = screen.getByText( 'Code is Poetry' ); | ||
| const badge = screen.getByTestId( testid ); |
There was a problem hiding this comment.
Tweaked to be more resilient against internal DOM changes.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
tyxla
approved these changes
Jan 2, 2025
I think we're good for now, as this is ideally something that "just works" without the consumer thinking about it. Also not sure how much we want to guarantee the specifics of this behavior as part of the backwards compatibility contract. |
bph
pushed a commit
to bph/gutenberg
that referenced
this pull request
Jan 8, 2025
* Badge: Support text truncation * Stabilize tests against internal DOM changes * Limit width to container * Add changelog Co-authored-by: mirka <[email protected]> Co-authored-by: tyxla <[email protected]> Co-authored-by: ciampo <[email protected]> Co-authored-by: jameskoster <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #68091
What?
Add text truncation support to
Badge.Testing Instructions
In the Storybook for Badge, use Dev Tools to add a width restriction to
.components-badge, for examplewidth: 80px. Alternatively, add a width restriction to a parent conatiner.Screenshots or screencast