Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query Total block: Reduce concatenation in the output text #68150

Merged
merged 3 commits into from
Dec 20, 2024

Conversation

sarthaknagoshe2002
Copy link
Contributor

@sarthaknagoshe2002 sarthaknagoshe2002 commented Dec 19, 2024

What?

Addresses the changes suggested here #67629 (comment) & #67629 (comment) for #67629

CC:- @swissspidy @fabiankaegy @gziolo

@sarthaknagoshe2002 sarthaknagoshe2002 changed the title Reduce concatenation in the output text Reduce concatenation in the output text in query-total block Dec 19, 2024
Copy link

github-actions bot commented Dec 19, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: sarthaknagoshe2002 <[email protected]>
Co-authored-by: swissspidy <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@swissspidy swissspidy added [Type] Enhancement A suggestion for improvement. Internationalization (i18n) Issues or PRs related to internationalization efforts [Block] Query Total Affects the query total block labels Dec 19, 2024
@swissspidy swissspidy changed the title Reduce concatenation in the output text in query-total block Query Total block: Reduce concatenation in the output text Dec 20, 2024
@swissspidy swissspidy enabled auto-merge (squash) December 20, 2024 08:55
@swissspidy swissspidy merged commit 5f22b7c into WordPress:trunk Dec 20, 2024
61 checks passed
@github-actions github-actions bot added this to the Gutenberg 20.0 milestone Dec 20, 2024
@sarthaknagoshe2002 sarthaknagoshe2002 deleted the query-total/concat-bug branch December 20, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Query Total Affects the query total block Internationalization (i18n) Issues or PRs related to internationalization efforts [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants