Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Inserter category tabs: avoid unnecessary aria-label #68160

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Fix: Inserter category tabs: avoid unnecessary aria-label #68160

merged 1 commit into from
Dec 20, 2024
+0 −1

Conversation

Rishit30G
Copy link
Contributor

@Rishit30G Rishit30G commented Dec 20, 2024 •
edited by Mamaduka
Loading

What?

This PR removes the unnecessary aria-label which is part of <Tabs.Tab> component

Why?

Fixes #68138

How?

aria-label={ category.label } is now not part of <Tabs.Tab> to avoid confusion to screen readers as we already have content present inside <Tabs.Tab>

@Rishit30G Rishit30G requested a review from ellatrix as a code owner December 20, 2024 01:49
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 20, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Rishit30G <[email protected]>
Co-authored-by: Mamaduka <[email protected]>
Co-authored-by: afercia <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@Mamaduka Mamaduka added [Type] Bug An existing feature does not function as intended [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] Block editor /packages/block-editor labels Dec 20, 2024
Mamaduka
Mamaduka approved these changes Dec 20, 2024
View reviewed changes
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing, @Rishit30G!

@Mamaduka Mamaduka added the props-bot Adding this label triggers the Props Bot workflow for a PR. label Dec 20, 2024
@github-actions github-actions bot removed the props-bot Adding this label triggers the Props Bot workflow for a PR. label Dec 20, 2024
@Mamaduka Mamaduka merged commit 854b84d into WordPress:trunk Dec 20, 2024
71 of 73 checks passed
@github-actions github-actions bot added this to the Gutenberg 20.0 milestone Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mamaduka Mamaduka Mamaduka approved these changes

@ellatrix ellatrix Awaiting requested review from ellatrix ellatrix is a code owner

Assignees
No one assigned
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] Block editor /packages/block-editor [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
Gutenberg 20.0
Development

Successfully merging this pull request may close these issues.

Inserter category tabs: avoid unnecessary aria-label
2 participants
@Rishit30G @Mamaduka