Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataViews: Don't render actions dropdown when all eligible ones are primary #68168

Merged
merged 1 commit into from
Dec 20, 2024
Merged

DataViews: Don't render actions dropdown when all eligible ones are primary #68168

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions packages/dataviews/src/components/dataviews-item-actions/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,13 +145,6 @@ export function ActionsMenuGroup< Item >( {
);
}

function hasOnlyOneActionAndIsPrimary< Item >(
primaryActions: Action< Item >[],
actions: Action< Item >[]
) {
return primaryActions.length === 1 && actions.length === 1;
}

export default function ItemActions< Item >( {
item,
actions,
Expand Down Expand Up @@ -184,7 +177,8 @@ export default function ItemActions< Item >( {
);
}

if ( hasOnlyOneActionAndIsPrimary( primaryActions, actions ) ) {
// If all actions are primary, there is no need to render the dropdown.
if ( primaryActions.length === eligibleActions.length ) {
return (
<PrimaryActions
item={ item }
Expand Down
Loading