Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverting stablization block support #68196

Open
wants to merge 21 commits into
base: trunk
Choose a base branch
from

Conversation

karthick-murugan
Copy link
Contributor

@karthick-murugan karthick-murugan commented Dec 20, 2024

What?

Reverting the changes of this PR #67552 as mentioned in this PR #68163

Why?

The approach taken to block support stabilization ironically needs some further time to stabilize itself

How?

Reverts the commits from the PRs listed above.

Testing Instructions

  1. Add a variety of different blocks that opt into typography supports. Ensure both static and dynamic blocks are covered.
  2. Apply some global typography styles for the blocks being tested.
  3. Select the individual block instances and apply new typography styles to override global styles. Confirm these are applied correctly in the editor.
  4. Save and confirm the typography support styles are correctly applied on the frontend.
  5. Back in the editor, cross check the default controls defined in the blocks' block.json with the controls displayed by default in the block inspector.
  6. Repeat the process from 1-5, this time checking border block supports function as before.
  7. Confirm that blocks that skip the serialization of block support styles and classes still function e.g. Images with borders etc.

Copy link

github-actions bot commented Dec 20, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: karthick-murugan <[email protected]>
Co-authored-by: ramonjd <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core, Gutenberg Plugin.
  • Labels found: .

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

@ramonjd
Copy link
Member

ramonjd commented Dec 22, 2024

Thanks for preparing this PR @karthick-murugan but @aaronrobertshaw had already prepared a revert PR for the stabilization supports for typography, border and others.

We can close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants