-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Menu: use ariakit types #68206
base: trunk
Are you sure you want to change the base?
Menu: use ariakit types #68206
Conversation
Flaky tests detected in bfc6593. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12455409108
|
9c9c85f
to
a6d5fc1
Compare
a6d5fc1
to
bfc6593
Compare
* @ignore | ||
*/ | ||
store?: Ariakit.MenuItemProps[ 'store' ]; | ||
} | ||
|
||
export interface MenuCheckboxItemProps | ||
extends Omit< MenuItemProps, 'prefix' | 'hideOnClick' > { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed the extends
syntax so that each component uses the correct ariakit types (ie. Menu.Item
uses Ariakit.MenuItemProps
, Menu.CheckboxItem
uses Ariakit.MenuItemCheckboxProps
, and Menu.RadioItem
uses Ariakit.MenuItemRadioProps
* | ||
* @default false | ||
*/ | ||
hideOnClick?: boolean; | ||
disabled?: Ariakit.MenuItemRadioProps[ 'disabled' ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added an explicit false
value for the disabled
prop — this is also reflected in the code when destructuring props
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
What?
Refactor
Menu
's types to re-use ariakit's types, and enhance prop descriptions.Why?
Menu
's propsHow?
Importing and using type definitions from
@ariakit/react
Next steps
Menu
to auto-generated READMEopen
-related props to popover componentMenuPopoverProps
(eg.portal
,preventBodyScroll
...)Testing Instructions
trunk