Widget Editor: Focus toggle button when the global inserter is closed #68216
+55
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +20 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
t-hamano
commented
Dec 22, 2024
Comment on lines
+86
to
90
| // When the block is focused, the global inserter is closed, | ||
| // which in turn focuses the global inserter toggle. | ||
| // So we need to explicitly focus the paragraph block again. | ||
| await addedParagraphBlockInFirstWidgetArea.focus(); | ||
| await addedParagraphBlockInFirstWidgetArea.focus(); |
There was a problem hiding this comment.
This may seem really weird, but in the widget editor, when the content area is clicked, the global inserter is closed. As a result of this PR, the global inserter toggle is focused, so we have to focus the block again.
dfb65b4f1f445abe11a98aa0492327ff.mp4
I've also submitted #67838 to not close the global inserter when the content area is focused. If we can move forward with that PR, we won't need this hack anymore.
|
Flaky tests detected in 4e043a2. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12450366614
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
To prevent focus loss in the widget editor, the inserter toggle gets focus when the following actions are performed:
Why?
a11y. Similar implementations exist in the
editorpackage, but the widget editor is implemented differently and must be implemented separately.Testing Instructions
Testing Instructions for Keyboard
You should be able to do the same thing using just the keyboard.
Screenshots or screencast
cc3c9ce84a11d2018cf618af9360d788.mp4