Editor: Include additional details when saving post fails #68360
+10
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +28 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 1109e42. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12554707369
|
Mamaduka
force-pushed
the
update/save-post-error-notice-messages
branch
from
53fcf9c to
1109e42
Compare
ramonjd
reviewed
Jan 2, 2025
| // Check if message string contains HTML. Notice text is currently only | ||
| // supported as plaintext, and stripping the tags may muddle the meaning. | ||
| return message && ! /<\/?[^>]*>/.test( message ); | ||
| } ); |
There was a problem hiding this comment.
Thanks for having a go at this 👍🏻
The extra context is definitely helpful, but I'm wondering if there's a bit too much in there. It might also be confusing for editors.
Before
After
I expect that it's difficult to know which error message is the most helpful. 🤔
Forgetting everything we know about Gutenberg/WordPress, as a user, it'd be helpful to know what failed and why, nothing else. E.g.,
The post couldn't be saved. The post password must be a maximum of 255 characters and contain only letters, numbers or special characters such as "!@#$%^&*".
I expect this would require making the error messages more friendly in the backend. For example, what's invalid is pretty obscure. And the lengths check depends on the database type.
Maybe a hook that passes in the error code, field type so that consumers (a.k.a the block editor) can write their own messages 🤷🏻
There was a problem hiding this comment.
@peterwilsoncc will have a better idea I think 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #64158.
PR updates the
getNotificationArgumentsForSaveFailbuilder to include additional error messages returned by REST API.Why?
Additional details inform users how to fix the problem.
Testing Instructions
Long password
Testing Instructions for Keyboard
Same.
Screenshots or screencast